Repository navigation
Conversation
|
This PR (HEAD: 2664e2b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/833524. Important tips:
|
2664e2b to
b3d480e
Compare
|
This PR (HEAD: b3d480e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/833524. Important tips:
|
|
Message from Emmanuel Odeke: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-09-16T07:19:31Z","revision":"d5433df617ab3e03b861c80d2bba645573693f86"} Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from Emmanuel Odeke: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5137>) Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from Joseph Tsai: Patch Set 2: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-10-09T18:12:25Z","revision":"d5433df617ab3e03b861c80d2bba645573693f86"} Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from Joseph Tsai: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_8495>) Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/833524. |
When the prefix or indent contains characters that v2 rejects, the v1 emulation formats with placeholder spaces of the same length and rewrites them with the original strings afterwards. The rewrite ran in a defer, so it ran after the trailing whitespace of src had already been appended and overwrote that whitespace as if it were indentation; with an empty indent it looped forever. Move the logic before the trailing whitespace is appended and avoid a defer. Also, add a test to both v1 and v1in2 to codify this behavior. This only modifies code that is compiled in under goexperiment.jsonv2. Fixes golang#81547
b3d480e to
ef1869a
Compare
|
This PR (HEAD: ef1869a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/833524. Important tips:
|
When the prefix or indent contains characters that v2 rejects,
the v1 emulation formats with placeholder spaces of the same length
and rewrites them with the original strings afterwards.
The rewrite ran in a defer, so it ran after the trailing whitespace of
src had already been appended and overwrote that whitespace as if it
were indentation; with an empty indent it looped forever.
Move the logic before the trailing whitespace is appended
and avoid a defer.
Also, add a test to both v1 and v1in2 to codify this behavior.
This only modifies code that is compiled in under goexperiment.jsonv2.
Fixes #81547