[PHP 8.6] Override on class constants, __debugInfo on enums, attribute API audit

[lisachenko]

Refs #225

What is done

1. #[\Override] on class constants

New stub tests/Stub/FileWithOverrideConstants86.php covers the attribute on a class constant inherited from an abstract parent, on an interface constant re-declared by an extending interface, on an interface constant implemented by a class, and on enum constants — alone, combined with a userland attribute inside the same attribute group, and combined with a repeated userland attribute in separate groups.

AttributeResolverTrait already resolved constant attributes, so no engine change was needed for the resolution itself; the new tests/Php86MiscParityTest.php asserts names, arguments, isRepeated(), filtering by name and the AST node of every attribute, plus full parity with native reflection on 8.6.

2. __debugInfo() on enums

New stub tests/Stub/FileWithDebuggableEnums86.php declares a pure enum and a backed enum with __debugInfo() (plus one enum without it as a negative case). The parsed ReflectionClass/ReflectionEnum report it as an ordinary method (hasMethod(), getMethods(), visibility, return type, declaring class) and match native reflection method-for-method on 8.6.

3. Attribute API additions (audit + implementation)

Diffing get_class_methods()/class constants of every Reflection* class between the local php (8.5.9) and php8.6 (8.6.0beta1) binaries gives the complete list of 8.6 reflection additions:

Class	Added in 8.6.0beta1	Handled here
ReflectionAttribute	getShortName(), getNamespaceName(), inNamespace()	implemented in src/ReflectionAttribute.php
ReflectionConstant	inNamespace()	mirrored in src/ReflectionConstant.php
ReflectionParameter	getDocComment()	out of scope — #221
ReflectionProperty	isReadable(), isWritable()	out of scope — #222

No new Reflection* classes and no new class constants appear in the beta.

The three ReflectionAttribute methods cannot simply be inherited: the internal implementations read the attribute structure that is never initialized for a parsed attribute, so on 8.6 they fatal today:

$ php8.6 probe.php     # parsed attribute from this library, before the fix
getShortName     => Error: Internal error: Failed to retrieve the reflection object
getNamespaceName => Error: Internal error: Failed to retrieve the reflection object
inNamespace      => Error: Internal error: Failed to retrieve the reflection object

They are now resolved from the attribute name itself (through getName(), so the anonymous subclass used by ReflectionConstant keeps working) and are asserted equal to the native results on 8.6.

ReflectionAttribute::getCurrent() does not exist in 8.6.0beta1 — php8.6 -r 'var_dump(method_exists(ReflectionAttribute::class, "getCurrent"));' prints bool(false) — so nothing is implemented for it. testAttributeApiAdditionsAreEitherImplementedOrAbsent() marks itself incomplete as soon as a runtime ships the method, and otherwise asserts that every native ReflectionAttribute method is implemented by the parsed one.

Two more verified behaviours worth recording:

• #[\Override] on a constant is validated at link time, exactly like on methods: Foo::BAR has #[\Override] attribute, but no matching parent constant exists — the stub therefore always declares a real parent/interface constant.
• The \Override attribute itself now declares the targets 28 (TARGET_METHOD | TARGET_PROPERTY | TARGET_CLASS_CONSTANT) instead of 12 on 8.5, where loading such a constant fails with Attribute "Override" cannot target class constant.

Parity fixes required by the above

• Named attribute arguments were collapsed into a positional list by AttributeResolverTrait, ReflectionAttribute::getNode() and ReflectionConstant::getAttributes(); native reflection keys them by name (['tag' => 'weight', 'priority' => 5]). They are now keyed the same way, which is what the new 8.6 parity assertions compare against. Two expectations in ReflectionConstantTest that documented the old shape were updated.
• ReflectionClassConstant::__toString() did not print the doc comment of the constant, while native reflection does. It does now — this also turns four previously skipped __toString parity data sets green (ClassWithPhp56ArrayConstants::A/B, ClassWithPhp56ComplexConstantsAndInheritance::K/L... skipped count drops from 133 to 129 on 8.6).

Stub loading convention

Both stubs parse on any runtime but only compile on 8.6, so they are resolved through a CallableLocator in the new test (like FileWithPropertyHooks84.php) and are never yielded by AbstractTestCase::getFilesToAnalyze(), whose providers include_once every stub. Every assertion that needs the stub loaded is guarded by PHP_VERSION_ID >= 80600.

Local results

• vendor/bin/phpunit on PHP 8.5.9 — OK, but there were issues! Tests: 13752, Assertions: 15474, Skipped: 131, Incomplete: 2 (no failures; baseline on master: 13743 tests, 133 skipped, 2 incomplete)
• php8.6 vendor/bin/phpunit on PHP 8.6.0beta1 — OK, but there were issues! Tests: 13752, Assertions: 15582, Skipped: 129, Incomplete: 3 (no failures; the three incompletes are the pre-existing Inherited methods should contain inherits section for the method __toString #55, [PHP8.6] ReflectionParameter::getDocComment() — parameter doc comments #221 and [PHP8.6] ReflectionProperty::isReadable() / isWriteable() emulation #222 ones)
• vendor/bin/phpstan analyse src --no-progress — [OK] No errors (level 10)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Sy8BcM8ivUEpu8uVm7wADn

---

Generated by Claude Code