test: drop golang.org/x/sync dependency (errgroup → sync.WaitGroup)#59
Merged
Conversation
Drops the golang.org/x/sync dependency, which was only used by the test suite (errgroup in local_counter_test.go). The concurrent test goroutines now report failures directly via t.Errorf, which is safe for concurrent use, so errgroup's error aggregation is unnecessary. Suggested by @lrstanley in #57 as part of reducing the module's dependency footprint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
golang.org/x/syncdependency, which was only used by the test suite (errgroupinlocal_counter_test.go). The concurrent test goroutines now report failures directly viat.Errorf(safe for concurrent use), soerrgroup's error aggregation isn't needed.This is one part of reducing the module's dependency footprint as suggested by @lrstanley in #57. Credit for the idea goes to them.
Note:
x/syncis a test-only dependency, so it doesn't propagate to consumers' builds — the benefit here is a tidiergo.modrather than a change to the dependency graph downstream users see. Thezeebo/xxh3part of #57 is handled/discussed separately.go test ./...passesgo mod tidydropsgolang.org/x/syncfromgo.mod/go.sum🤖 Prepared with the help of Claude (AI), reviewed before opening.