Repository navigation
fix!: require React Native 0.83 (Expo SDK 55) - #58
Conversation
Before React Native 0.82, iOS drops a view that is not recycled without calling invalidate, and invalidate is the only place Nitro's generated component calls onDropView from for this view. On 0.81 every closed viewer kept its PDFView, document, callbacks, search and form, its load kept running and its pin in Caches/BetterPdf/open stayed (#26). No Expo SDK ships 0.82 (SDK 54 has 0.81, SDK 55 has 0.83.10), so the floor is 0.83, the oldest line the Expo example builds on. There, in a Release build of the example on the iOS simulator, 10 open/close cycles called onDropView 10 times and left no PDFView, PDFDocument or PDFPage; the 10 HybridBetterPdfView objects left wait for a Hermes GC, which a Release build cannot force. The library also compiles on Android at SDK 55, and its JVM tests pass. The README, the migration guide, the research notes and the issue templates now state the same minimum. BREAKING CHANGE: react-native >= 0.83 (Expo SDK 55) is required. React Native 0.81 (Expo SDK 54) and 0.82 are no longer supported; on 0.81 iOS never released closed viewers.
native-build.yml takes an expo-sdk input. When set, the example moves to that SDK with expo install --fix before the unchanged prebuild, pod install, xcodebuild and Gradle steps, and package/node_modules is removed. package/ keeps react-native 0.86.3 as a devDependency, and the library's Android codegen fails on that nested copy with the older parser. Apps have no such copy. native-minimum.yml calls it with SDK 55 weekly, by hand, and on pull requests that edit either workflow. Run locally at SDK 55, the same steps compile the library for iOS and Android. Closes #26
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
Issue #26 requires a consistent minimum, iOS teardown at that minimum, and a CI build. The package peer range, README, migration guide, research notes, and issue templates state React Native 0.83 and … |
Provide reviewable evidence for React Native 0.83 / Expo SDK 55 that 10 open/close cycles followed by GC leave no HybridBetterPdfView objects, or provide an automated equivalent. Confirm the minimum workflow run if that result is required… |
-
Check name Status Explanation Title check The title is concise, uses the required type prefix, and accurately describes the main change: raising the minimum React Native and Expo SDK versions. Description check The description directly explains the dependency changes, CI workflow additions, breaking impact, verification steps, and known limitations. Out of Scope Changes check The changed files support issue #26. The workflow input and minimum workflow build the example's native library through the Expo SDK 55 environment. The documentation and issue-template updates synchr…Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Security Check No medium, high, or critical vulnerability is introduced. The only executable change adds an Expo SDK input to the reusable native-build workflow, but the sole caller supplies the fixed value 55; th…Full details: Out of Scope Changes check
-
Explanation
The changed files support issue
#26. The workflow input and minimum workflow build the example's native library through the Expo SDK 55 environment. The documentation and issue-template updates synchronize the new support floor. The contributing-guide update documents the new minimum-build check. No unrelated product behavior, API, or release workflow change is demonstrated.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (9 skipped: 9 unsupported.)
Full details: Security Check
-
Explanation
No medium, high, or critical vulnerability is introduced. The only executable change adds an Expo SDK input to the reusable native-build workflow, but the sole caller supplies the fixed value
55; the value is passed through an environment variable and quoted in the shell command. Both jobs usecontents: read, checkout disables persisted credentials, and no secrets or write-capable tokens are exposed. The remaining changes only update documentation, issue templates, and a peer dependency. No prior security threads or current findings require re-reporting.
-
Full details: Linked Issues check
-
Explanation
Issue
#26requires a consistent minimum, iOS teardown at that minimum, and a CI build. The package peer range, README, migration guide, research notes, and issue templates state React Native 0.83 and Expo SDK 55.native-minimum.ymlinvokes the reusable build with SDK 55 on a schedule, manually, and for workflow changes. The existing generatedinvalidatepath applies from React Native 0.82, so it covers the selected floor. The PR reports 10 successfulonDropViewcalls and no remaining PDF objects, but it did not measure the required post-GCHybridBetterPdfViewcount. The new CI workflow had also not run at review time.Resolution
Provide reviewable evidence for React Native 0.83 / Expo SDK 55 that 10 open/close cycles followed by GC leave no
HybridBetterPdfViewobjects, or provide an automated equivalent. Confirm the minimum workflow run if that result is required for the conclusion.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What does this change?
Raises the minimum to React Native 0.83 / Expo SDK 55 and adds a CI job that builds the example there. Closes #26.
Before React Native 0.82, iOS drops a view that is not recycled without calling
invalidate(RCTComponentViewRegistry.mm:0.81-stableand0.82-stablediffer by exactly that call). For this view,invalidateis the only place Nitro's generated component callsonDropViewfrom. On 0.81 / Expo SDK 54, which the README listed as supported, closed viewers were never torn down. Each kept itsPDFView, document, callbacks (so #16 did not apply), search and form, and its loads and pins stayed.Why 0.83 and not 0.82: no Expo SDK ships 0.82 (SDK 54 has 0.81, SDK 55 has 0.83.10). The example is an Expo app, so 0.83 is the oldest line CI can build.
peerDependencies:react-native >=0.83. The README, the migration guide (which still said 0.78+), the research notes and both issue templates now say the same.native-build.ymltakes anexpo-sdkinput. When it is set, the example moves to that SDK (expo install expo@^N --fix) before the unchanged prebuild, pod install, xcodebuild and Gradle steps, andpackage/node_modulesis removed.package/keeps react-native 0.86.3 as a devDependency, and the library's Android codegen fails on that nested copy with 0.83's parser; an app has no such copy. Without the input nothing changes, sonative.ymlandrelease.ymlare untouched.native-minimum.ymlcalls it with SDK 55 weekly, by hand, and on pull requests that edit either workflow, so this PR runs it.Breaking: apps on React Native 0.81 (Expo SDK 54) or 0.82 fall outside the peer range. The first commit has a
BREAKING CHANGE:footer. Keep the!in the squash title so the release notes call it out.Not done: gating
release.ymlon the minimum build. The issue suggests it, but it adds a second macOS job to every release and could block an urgent patch when something breaks on Expo's side.How was it verified?
Locally on Expo SDK 55 / React Native 0.83.10 (macOS, Xcode 27.1), with the workflow's steps:
pod installandxcodebuildof theNitroBetterPdfscheme for the simulator succeed.-[HybridBetterPdfViewComponent invalidate]is in the object file; Nitro compiles it only for React Native 0.82 and newer.:react-native-better-pdf:assembleDebugandtestDebugUnitTestsucceed, and the 273 JVM tests pass. Withpackage/node_modulesleft in place, codegen fails withUnable to determine event arguments for "onModeChange".NSLoginonDropView:onDropView10 times.heapshowed noPDFView,PDFDocumentorPDFPageobjects.HybridBetterPdfViewobjects (about 1.3 KB each) remained, waiting for a Hermes GC that a Release build cannot force. The "after a GC" half of the acceptance criterion was therefore not measured here; fix: release closed viewers and their documents #16 measured it on 0.86.IPHONEOS_DEPLOYMENT_TARGET=15.1with Xcode 27.1, because react-native-blob-util's privacy bundle targets iOS 11.0. CI compiles only the library scheme, like the existing job, so it is not affected.Native (minimum)checks are its first run.bun run lint,bun run typecheck,bun run testandactionlintpass.Not reproduced on 0.81 itself (there is no SDK 54 build). The 0.81 behaviour comes from React Native's source.
Scope
Checklist
bun run lint,bun run typecheckandbun run testpasscd package && bun run specswas re-run andpackage/nitrogen/is committed with it: not changeddocs/api.md, the feature's guide indocs/guides/, the README's capability matrix anddocs/api-design.mdare updated: not changedNeed help on this PR? Tag
@codesmith-botwith what you need.