ci: fix npm OIDC token exchange endpoint and audience#109
Merged
Conversation
- Audience: 'npm' → 'npm:registry.npmjs.org' - Endpoint: /-/npm/v1/oidc/token → /-/npm/v1/oidc/token/exchange/package/@Girs%2fgnome-shell - OIDC token in request body → Authorization: Bearer header, body is {} Matches the implementation in gjsify/packages/infra/cli/src/utils/npm-oidc.ts
Collaborator
|
@JumpLink You are using an outdated action: https://github.com/gjsify/gnome-shell/actions/runs/27642358445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OIDC token exchange was failing with HTTP 404 because:
'npm'instead of'npm:registry.npmjs.org'/-/npm/v1/oidc/tokeninstead of/-/npm/v1/oidc/token/exchange/package/@girs%2fgnome-shellAuthorization: Bearer <token>with an empty{}bodyFix
'npm'→'npm:registry.npmjs.org'/-/npm/v1/oidc/token→/-/npm/v1/oidc/token/exchange/package/@girs%2fgnome-shellAuthorization: BearerheaderThese fixes are derived from the reference implementation in
gjsify/gjsifyatpackages/infra/cli/src/utils/npm-oidc.ts.