ci: switch release publish to npm OIDC Trusted Publishing#101
Merged
Conversation
Remove NPM_TOKEN secret dependency. npm CLI (v10+, shipped with Node 22) auto-exchanges the GitHub Actions OIDC token at npm's /-/npm/v1/oidc/token endpoint when id-token: write is set and no NODE_AUTH_TOKEN is present. Key points: - Drop registry-url from actions/setup-node to prevent the NODE_AUTH_TOKEN placeholder from suppressing OIDC exchange - Switch from `yarn npm publish` (no OIDC support) to `npm publish` - Move prerelease tag expression into an env var (avoid inline expression injection in run commands)
swsnr
approved these changes
Jun 16, 2026
swsnr
left a comment
Collaborator
There was a problem hiding this comment.
Not too familiat with the whole npm publishing workflow, but looks solid I guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release CI for
50.0.1failed becauseNPM_TOKENis empty/missing in thenpm-releaseenvironment.Fix
Switch from Yarn token-based publishing to npm OIDC Trusted Publishing (no long-lived secret needed).
What changed
NPM_TOKENenv var and secret references entirelyregistry-urlfromactions/setup-node— when set, it injects aNODE_AUTH_TOKENplaceholder that makes npm skip OIDC and fall back to token auth (same pattern as gjsify/gjsify release.yml)yarn workspace @girs/gnome-shell npm publish(no OIDC support in Yarn) tonpm publish packages/gnome-shell(npm CLI v10+ exchanges the GitHub OIDC token automatically)env:variable to avoid inline expression injection inrun:commandsRequired follow-up on npmjs.com
Before re-running a release, configure a Trusted Publisher for
@girs/gnome-shell:gjsifygnome-shellrelease.ymlnpm-releaseOnce configured, re-publish by re-creating the
50.0.1release or tagging a new version.