Repository navigation
Disclose table rails per track, with grips and seam inserts - #359
Merged
Merged
Conversation
Collaborator
Author
|
Review: Changes needed Checked in a real browser (1440x900, 390x844 touch and narrow, reduced motion) against a seeded document: 3-column table, 20-column table, 100-row table, tables right under a paragraph. Blocking
Non-blocking
What works well
CI: only the design-contract review hashes fail ( |
Collaborator
Author
|
Thanks. All five points are addressed on
Tab reachability is noted as a follow-up in the PR body. CI: e2e and container pass. The only failure is the |
Only the pointed or caret row and column draw a grip, with a six-dot handle. Inserts appear on their seam with a line across the table. Targets grow to 24px, rails fade in, and row-rail tooltips sit outside the rail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rail container now passes the pointer through, so the paragraph above a table stays clickable; only grips, shown buttons and the seams beside the pointed track take it. Rails clip to the document scroller, the remove button hides while an insert is aimed, pointed-cell updates skip no-ops, and the grip glyph uses spacing tokens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A row rail sits in the gutter, which can fall outside the scroller's own box; clipping it horizontally cut off its buttons and their hit area. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
design/table-rails
branch
from
October 8, 2026 14:38
6c6c13e to
77c2754
Compare
MaggieAppleton
enabled auto-merge (rebase)
October 8, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Table rails showed every row and column as soon as any cell was hovered. Their controls were cramped, and row tooltips covered nearby actions.
What changed
Verification
49 focused table tests,
bun run types,bun run ci, andbun run buildpass on the restacked branch. GitHub's browser suite will check the two new rail scenarios on the final published head.Known follow-up
Tab and Shift+Tab do not yet leave the editor, so the rail grips are reached by screen reader or programmatic focus. Their existing keyboard move shortcuts work once focused.
Visuals