Repository navigation
Keep the research composer visible as one surface - #355
Conversation
b177451 to
8e2c02c
Compare
|
Review: Changes needed (one small visual bug; the rest is good) Reviewed in a real browser (headless Playwright against a fake-GitHub server on this branch), desktop 1440x900 and phone 390x844, plus a 30-80ms frame sequence. CI: only the design-contract review hashes fail ( Findings
Verified OK
|
|
Thanks. Addressed in 0f995d2.
Also from the earlier round: any key, pointer, touch or wheel input now ends the reveal, so it never fights the reader. CI: e2e passed, 388 tests with 1 unrelated flaky, |
Place the /research draft with a unit-tested placeDraft(): below its anchor block when it fits, flipped above near the bottom edge, pinned when neither fits, and clamped to the visible scroller inside the visual viewport. On open and on viewport resize (on-screen keyboard) the scroller reveals the anchor line and the draft. The composer is now a single field surface with the focus ring on the card, inline status and error text in its footer, and popover enter/exit motion. Focus returns to the question after a failed start, and a draft whose reference the server rejected (document rebuilt right after placement) reopens with an inline error instead of vanishing. The plan scroller no longer writes back every reported scroll offset, which cancelled smooth scrolls; it restores the saved offset only on (re)mount. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rebuild could misfire it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A fast click elsewhere right after opening could be pulled back by the remaining reveal window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A draft whose anchor is partly scrolled out no longer draws over the document tabs. The opening reveal goes back to the scroll offset the reader had when the draft opened if it fits there, and jumps instead of gliding when the trip is longer than the pane. The new e2e places its caret by clicking, since End scrolls the document on macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4f4906b to
243ec28
Compare
Why
The
/researchcomposer could open above the visible document pane and hide its focused field. Nested borders also made it look like a card inside a card.What changed
Known follow-up
Pressing Enter can still jump the document scroller because of Lexical caret scrolling. This PR keeps the research composer visible when that happens; it does not change the underlying jump.
Verification
The 36 focused placement and research tests,
bun run types, andbun run cipassed locally on the rebased commits. Required GitHub checks will run on the final published head.Visuals
Before:
After:
Near bottom:
Phone: