fix: add cli-proxy container image to release workflow#1774
Conversation
Add build-cli-proxy job to release.yml following the same pattern as api-proxy: build+push to GHCR, cosign signing, SBOM generation, and SBOM attestation. Also update docs/releasing.md to document the new cli-proxy image. The predownload logic already includes cli-proxy support from PR #1730. Fixes #1746 Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/d6d42f21-06c7-45b4-8d7f-f60f1d597851 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes release automation for the --enable-cli-proxy feature by ensuring the cli-proxy container image is built and published to GHCR as part of the release workflow, and updates release documentation accordingly.
Changes:
- Add a new
build-cli-proxyjob to.github/workflows/release.ymlto build/push multi-archcli-proxyimages, sign them with cosign, and generate+attest an SBOM. - Update the
releasejob to depend onbuild-cli-proxy. - Update
docs/releasing.mdto includecli-proxyin image lists, verification steps, and local build instructions.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds CI job to publish cli-proxy image (multi-arch, cosign, SBOM) and wires it into the release dependencies. |
docs/releasing.md |
Documents cli-proxy as a release artifact and includes it in verification and local testing instructions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This comment has been minimized.
This comment has been minimized.
🧪 Smoke Test Results
PR: fix: add cli-proxy container image to release workflow Overall: PASS (core connectivity tests passed; file test skipped due to unrendered template variables)
|
This comment has been minimized.
This comment has been minimized.
Smoke Test: GitHub Actions Services Connectivity ✅
All checks passed. (
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
Smoke test results (run 24112018856)
Overall: PASS
|
This comment has been minimized.
This comment has been minimized.
|
🔮 The ancient spirits stir; this smoke-test agent has walked these halls.
|
--enable-cli-proxyfails on any non---build-localrun because the release workflow never builds/publishes thecli-proxyimage to GHCR. The image reference in docker-compose resolves to a tag that doesn't exist:Changes
.github/workflows/release.yml— Addbuild-cli-proxyjob (same pattern asbuild-api-proxy: multi-arch build+push, cosign signing, SBOM generation + attestation). Add it to thereleasejob'sneedsarray.docs/releasing.md— Addcli-proxyto image lists, verification checklist, local build examples, and package visibility reference.Already in place (no changes needed)
src/commands/predownload.ts—resolveImages()already includescli-proxywhenenableCliProxyis set (landed in feat: phase 1 – gh CLI proxy sidecar with mcpg DIFC proxy #1730)containers/cli-proxy/Dockerfile— exists from feat: phase 1 – gh CLI proxy sidecar with mcpg DIFC proxy #1730