Skip to content

Update Node.js version and modify publish step#64

Open
gracepark wants to merge 1 commit into
mainfrom
gracepark-patch-1
Open

Update Node.js version and modify publish step#64
gracepark wants to merge 1 commit into
mainfrom
gracepark-patch-1

Conversation

@gracepark
Copy link
Copy Markdown

Copilot AI review requested due to automatic review settings May 8, 2026 20:15
@gracepark gracepark requested a review from a team as a code owner May 8, 2026 20:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the npm publish GitHub Actions workflow to support OIDC-based publishing with npm provenance, while also bumping the Node.js version used during the release publish job.

Changes:

  • Add job-level id-token: write permission for OIDC.
  • Update actions/setup-node from Node 22 to Node 24 for the publish job.
  • Switch npm publish step to npm publish --provenance and remove token-based auth usage.
Show a summary per file
File Description
.github/workflows/publish.yml Adjusts permissions and publish command for OIDC/provenance and bumps the Node version used during release publishing.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:23

  • This workflow publishes/tests with Node 24, while the main CI workflow currently runs on Node 22.x only. That means Node 24-specific issues would only be discovered at release time. Consider aligning the publish workflow to the CI version, or adding Node 24 to the CI matrix so publish behavior is exercised before cutting a release.
        with:
          node-version: 24
          registry-url: https://registry.npmjs.org/
          cache: npm
      - run: npm ci
      - run: npm test
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants