Update Node.js version and modify publish step#64
Open
gracepark wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to support OIDC-based publishing with npm provenance, while also bumping the Node.js version used during the release publish job.
Changes:
- Add job-level
id-token: writepermission for OIDC. - Update
actions/setup-nodefrom Node 22 to Node 24 for the publish job. - Switch npm publish step to
npm publish --provenanceand remove token-based auth usage.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Adjusts permissions and publish command for OIDC/provenance and bumps the Node version used during release publishing. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:23
- This workflow publishes/tests with Node 24, while the main CI workflow currently runs on Node 22.x only. That means Node 24-specific issues would only be discovered at release time. Consider aligning the publish workflow to the CI version, or adding Node 24 to the CI matrix so publish behavior is exercised before cutting a release.
with:
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npm ci
- run: npm test
- Files reviewed: 1/1 changed files
- Comments generated: 1
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
OIDC migration