Skip to content

Even easier Immediates#583

Merged
cwfitzgerald merged 5 commits into
gfx-rs:trunkfrom
Vipitis:immediates
Jun 12, 2026
Merged

Even easier Immediates#583
cwfitzgerald merged 5 commits into
gfx-rs:trunkfrom
Vipitis:immediates

Conversation

@Vipitis

@Vipitis Vipitis commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • cargo clippy reports no issues
  • [?] cargo doc reports no issues
  • cargo deny issues have been fixed or added to deny.toml
  • Human-readable change descriptions added to CHANGELOG.md under the "Unreleased" heading.
    • If the change does not affect the user (or is a process change), preface the change with "Internal:"
    • Add credit to yourself for each change: Added new functionality. @githubname

Description

While doing the v29 update for the python wrapper. I spotted that the descriptor already has a immediateSize field in webgpu.h webgpu-native/webgpu-headers#529
Also saw the limits being simplified in #575 so this makes it even simpler, although you still need the native only feature. I updated the example and it still works, please let me know if the changes to the wgpu.h headers are fine like this.

Related Issues

@lisyarus

lisyarus commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Nice! I think the changelog diff is a bit incorrect: it marks as released in v29 everything currently marked as unreleased, which isn't the case (there were new additions after v29). Apparently the current changelog in trunk contains both pre-v29 and post-v29 changes. Maybe just add your changes to unreleased for now, and then a separate PR would sort out the changelog itself?
@cwfitzgerald

@Vipitis

Vipitis commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

yeah, I quickly looked at the blame and all your recentt changes should probably move to the top as well. I just tried to have mine a little more correct for now. I can add a commit to move yours tomorrow, or maybe do it outside this PR?

@lisyarus

lisyarus commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

I'd suggest fixing the changelog in a separate PR, just to keep the history clean?

Comment thread ffi/wgpu.h

@cwfitzgerald cwfitzgerald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Music to my eyes!

Comment thread ffi/wgpu.h
@Vipitis

Vipitis commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

hey @cwfitzgerald I updated the enums (although there are other enums with gaps still remain, unrealted to the change here).

plus there is even even easier immediates for the set functions that got merged into the webgpu.h header: webgpu-native/webgpu-headers#588 so I will look into that PR next.

@cwfitzgerald

Copy link
Copy Markdown
Member

Could you rebase this, sorry for the long delay!

@Vipitis

Vipitis commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

rebased to newest trunk

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 12, 2026 20:50
@cwfitzgerald

Copy link
Copy Markdown
Member

Thanks!

@cwfitzgerald cwfitzgerald merged commit 61efac8 into gfx-rs:trunk Jun 12, 2026
33 checks passed
@Vipitis Vipitis deleted the immediates branch June 12, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants