Skip to content

ref(cmdk): Ensure nested settings pages are added to Cmdk#112750

Merged
rbro112 merged 2 commits intomasterfrom
ryan/04-10-ensure_nested_settings_pages_are_added_to_cmdk
Apr 14, 2026
Merged

ref(cmdk): Ensure nested settings pages are added to Cmdk#112750
rbro112 merged 2 commits intomasterfrom
ryan/04-10-ensure_nested_settings_pages_are_added_to_cmdk

Conversation

@rbro112
Copy link
Copy Markdown
Member

@rbro112 rbro112 commented Apr 10, 2026 •
edited
Loading

Ensures sub-pages are added to actions for settings nav. Might get a bit clobbered by #112262 , but I can rebase if needed

Tested locally and works great!
Screenshot 2026-04-10 at 4 04 44 PM

@rbro112 rbro112 requested a review from a team as a code owner April 10, 2026 23:00
@rbro112 Graphite App
Copy link
Copy Markdown
Member Author

rbro112 commented Apr 10, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 10, 2026
@rbro112 rbro112 changed the title Ensure nested settings pages are added to Cmdk ref(cmdk): Ensure nested settings pages are added to Cmdk Apr 10, 2026
sentry[bot]
sentry bot reviewed Apr 10, 2026
View reviewed changes
Comment thread static/app/components/commandPalette/useGlobalCommandPaletteActions.tsx Outdated
@rbro112 rbro112 force-pushed the ryan/04-10-ensure_nested_settings_pages_are_added_to_cmdk branch from e7c3d65 to a77a104 Compare April 13, 2026 20:01
@rbro112 rbro112 force-pushed the ryan/04-10-ensure_nested_settings_pages_are_added_to_cmdk branch from 907daae to d803310 Compare April 13, 2026 22:15
JonasBa
JonasBa approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can improve this and reduce the noise for orgs with large number of projects, but this looks great, thank you!

@rbro112 rbro112 merged commit 43ccf50 into master Apr 14, 2026
65 checks passed
@rbro112 rbro112 deleted the ryan/04-10-ensure_nested_settings_pages_are_added_to_cmdk branch April 14, 2026 15:57
@billyvg billyvg added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 14, 2026
@getsentry-bot
Copy link
Copy Markdown
Contributor

getsentry-bot commented Apr 14, 2026

PR reverted: d8b1be7

getsentry-bot added a commit that referenced this pull request Apr 14, 2026
@getsentry-bot @billyvg
Revert "ref(cmdk): Ensure nested settings pages are added to Cmdk (#1…
d8b1be7 
…12750)"

This reverts commit 43ccf50.

Co-authored-by: billyvg <79684+billyvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@JonasBa JonasBa JonasBa approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbro112 @getsentry-bot @JonasBa @billyvg