Repository navigation
fix(redash): skip unused password secret keys - #217
Open
kahirokunn wants to merge 1 commit into
Open
kahirokunn wants to merge 1 commit into
kahirokunn wants to merge 1 commit into
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
redash.existingSecretcurrently adds required references toldapBindDnPasswordandmailPassword, even when LDAP bind and SMTP authentication are not configured. If the existing Secret omits these unused keys, the Redash containers cannot start.Render
REDASH_LDAP_BIND_DN_PASSWORDonly whenredash.ldapBindDnis configured, andREDASH_MAIL_PASSWORDonly whenredash.mailUsernameis configured. Configured authentication still requires its password key; other environment variables and Secret references are unchanged.