Repository navigation
Add Knative support - #213
Closed
kahirokunn wants to merge 1 commit into
Closed
kahirokunn wants to merge 1 commit into
kahirokunn wants to merge 1 commit into
Conversation
kahirokunn
force-pushed
the
feature/knative-support
branch
2 times, most recently
from
June 18, 2026 02:24
bda5c60 to
1b6818e
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
feature/knative-support
branch
from
June 18, 2026 02:52
1b6818e to
520a83b
Compare
Contributor
Author
|
@ranyhb Hi ✋ PTAL. Thank you 🙏 |
This was referenced Aug 25, 2026
Collaborator
|
Thanks for this! I've opened #215, which consolidates this PR together with #211, #212, #213 and #214 into a single 4.1.0 release — they overlap in Your commit for the Knative Serving support is carried over as-is with you credited via Closing this one in favour of #215. |
This was referenced Aug 25, 2026
ranyhb
added a commit
that referenced
this pull request
Aug 25, 2026
* fix: imagePullSecrets rendering in pod specs The whitespace chomping on the `with .Values.imagePullSecrets` block trimmed the newline after the last pull secret entry, so `serviceAccountName` was glued onto it and rendering failed with `mapping values are not allowed in this context` whenever imagePullSecrets was set. Upstream: #211 Co-authored-by: braun1928 <24943487+braun1928@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: add worker component to selector labels redash.selectorLabels only emitted the chart name and release instance, so the adhocworker, genericworker and scheduledworker Deployments all rendered the same spec.selector and could adopt each other's Pods. Moves app.kubernetes.io/component out of redash.labels and into redash.selectorLabels, where a workerName in the context makes each worker's selector distinct. Upstream: #212 Co-authored-by: kahirokunn <22343391+kahirokunn@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: add Knative Serving support for the web server server.knative.enabled renders the Redash web server as a Knative Service instead of a Deployment; workers, scheduler, migrations, PostgreSQL and Redis stay on standard Kubernetes resources. The chart-managed service and ingress are skipped in that mode, and the helm test pod targets the cluster-local URL. Chart.yaml and the generated README are left to a follow-up commit so one version bump covers all four backported changes. Upstream: #213 Co-authored-by: kahirokunn <22343391+kahirokunn@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: test against Kubernetes 1.33-1.36 Moves the CI matrix off the 1.31/1.32 minors. The documented prerequisite is updated with the rest of the docs in the next commit, since PR #213 touches the same line. Upstream: #214 Co-authored-by: kahirokunn <22343391+kahirokunn@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: release 4.1.0 and reconcile the backported changes Resolves the overlaps between the four backported PRs: - Chart.yaml gets a single 4.1.0 bump rather than #211's 4.0.2 and #213's 4.1.0, and the missing trailing newline is restored. - The prerequisites line takes #214's Kubernetes 1.33-1.36 wording; #213 had rewritten the same line to 1.31-1.34. - #211's imagePullSecrets fix is applied to the Knative Service template as well, which #213 wrote before that fix existed. - CHANGELOG 4.1.0 covers all four changes and documents the manual step the worker selector fix needs: spec.selector is immutable, so the worker Deployments must be deleted before `helm upgrade`. - The "From 3.1 to 3.2" upgrade notes existed only in the generated README, so they are moved into README.md.gotmpl before regenerating and would otherwise have been lost. - charts/redash/README.md is regenerated with helm-docs, which also drops the postgresqlMigration rows for the values 4.0.0 removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: add CLAUDE.md Guidance for Claude Code working in this repo: the helm dependency build prerequisite, the lint/template/CI commands, the fact that charts/redash/README.md is generated (and that the pre-commit helm-docs hook writes the wrong path since the chart moved out of the top level), the chart-releaser version-bump requirement, and the template architecture around the shared redash.env helper. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: evaluate image.tag as a Helm template expression Wraps image.tag in `tpl` so umbrella charts can pass a templated value and have it resolve at render time instead of being emitted as a literal string. Plain string tags are unaffected: `tpl "25.8.0" .` returns "25.8.0". Consistent with the existing use of `tpl` for commonLabels, podLabels, annotations and extraObjects. Also applied to the Knative Service template added earlier in this branch, which #209 predates. The upstream PR also rewrote the root README.md with the chart's generated docs -- the result of running helm-docs from the repo root, where the pre-commit hook points. That hunk is left out. Upstream: #209 Co-authored-by: likesavabutworse <likesavabutworse@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: fix typos in documentation and values comments depreciated -> deprecated, overriden/overidden -> overridden, "it's own" -> "its own", traffuc -> traffic, and a duplicated "and". The upstream PR also patched the generated charts/redash/README.md directly; those fixes come from values.yaml and README.md.gotmpl here and land when the README is regenerated. Upstream: #210 Co-authored-by: shubhamg931 <shubhamg931@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci: keep testing Kubernetes 1.31 and 1.32 PR #214 swapped 1.31/1.32 out for 1.35/1.36. Widen the matrix to cover all six minors instead, so support for the older versions is not dropped silently, and restore the documented prerequisite to 1.31+. Also regenerates charts/redash/README.md so the documentation typo fixes and the image.tag change are reflected there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: add clusterDomain parameter and improve probe handling in Redash chart * ci: enhance CI workflow with linting and improved resource management for Minikube * ci: reduce Helm upgrade timeout from 10m to 5m for redash and redashup installations --------- Co-authored-by: braun1928 <24943487+braun1928@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: kahirokunn <22343391+kahirokunn@users.noreply.github.com> Co-authored-by: likesavabutworse <likesavabutworse@users.noreply.github.com> Co-authored-by: shubhamg931 <shubhamg931@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.