Skip to content

fix: define check_domain_dns before first use and fix 2 minor issues - #762

Open
Harbinder04 wants to merge 1 commit into
getlago:mainfrom
Harbinder04:fix/deploy-script-function-order
Open

fix: define check_domain_dns before first use and fix 2 minor issues#762
Harbinder04 wants to merge 1 commit into
getlago:mainfrom
Harbinder04:fix/deploy-script-function-order

Conversation

@Harbinder04

Copy link
Copy Markdown

Changes

  1. Function orderingcheck_domain_dns() was defined after it was called,
    causing check_domain_dns: command not found when LAGO_DOMAIN was
    already set in the environment. Moved the definition above its call site.
  2. Missing echo — the Docker Compose install-link line was missing the
    echo command, causing a command not found error when both Docker and
    Docker Compose are missing.
  3. Unquoted $pid — quoted "$pid" in spinner() to prevent globbing
    and word splitting.

Resolve: #761

@cla-check-bot

cla-check-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

Welcome back, @Harbinder04!

It looks like we still need your FLA signature on file. Please sign it here:

Sign the FLA

Once signed, this PR will be automatically updated.

@cla-check-bot

cla-check-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

Thanks, @Harbinder04! 🎉

Your CLA has been signed and is now on file. We'll proceed with the review shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: function ordering issue in deploy/deploy.sh

1 participant