fix: define check_domain_dns before first use and fix 2 minor issues - #762
Open
Harbinder04 wants to merge 1 commit into
Open
fix: define check_domain_dns before first use and fix 2 minor issues#762Harbinder04 wants to merge 1 commit into
Harbinder04 wants to merge 1 commit into
Conversation
Welcome back, @Harbinder04!It looks like we still need your FLA signature on file. Please sign it here: Once signed, this PR will be automatically updated. |
Thanks, @Harbinder04! 🎉Your CLA has been signed and is now on file. We'll proceed with the review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
check_domain_dns()was defined after it was called,causing
check_domain_dns: command not foundwhenLAGO_DOMAINwasalready set in the environment. Moved the definition above its call site.
echo— the Docker Compose install-link line was missing theechocommand, causing acommand not founderror when both Docker andDocker Compose are missing.
$pid— quoted"$pid"inspinner()to prevent globbingand word splitting.
Resolve: #761