docs: mark external_customer_id optional on GET /wallets - #558
Open
refus-lago wants to merge 1 commit into
Open
Conversation
The parameter was made optional in the API in late May 2026 (#5559), but the OpenAPI spec still marked it required, so the api-reference page incorrectly showed external_customer_id as required. When omitted, GET /wallets returns all wallets for the organization. Closes Pylon #5991 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
@refus-lago what do we do with this one? It's still in draft? |
refus-lago
marked this pull request as ready for review
August 14, 2026 20:11
Author
@sarkissianraffi Just marked ready for review. Anna approved here: Slack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Set
external_customer_idtorequired: falseonGET /wallets(findAllWallets) and reworded its description as an optional filter.Why
The parameter was made optional in the API in late May 2026 (#5559), but the OpenAPI spec still marked it
required: true, soapi-reference/wallets/get-allincorrectly showed it as required. Inlago-api,external_customer_idis a permitted filter that flows through.compactintoWalletsQuery; when omitted, all wallets for the organization are returned.Impact
Docs-only. The api-reference page will show
external_customer_idas optional, matching current API behavior.Closes Pylon #5991
🤖 Generated with Claude Code