Repository navigation
feat(python): Add geoarrow-types integration - #182
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
===========================================
+ Coverage 85.36% 96.72% +11.35%
===========================================
Files 59 4 -55
Lines 9673 61 -9612
Branches 957 0 -957
===========================================
- Hits 8257 59 -8198
+ Misses 1335 2 -1333
+ Partials 81 0 -81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The geoarrow-types package was introduced some time ago to replace the enums that were previously provided by Cython here. This replaces that interface with two functions:
type_spec_to_arrow()andarrow_to_type_spec(). Currently the CVectorType is used as a backend but I'd like to remove that in a future release.The idea is that
geoarrow.typesis the way to work with types and geoarrow-c is way to resolve that into a concrete type.