Skip to content

feat: add option to exclude artists/albums from global top lists#332

Open
hgcummings wants to merge 2 commits into
gabehf:mainfrom
hgcummings:Exclusions
Open

feat: add option to exclude artists/albums from global top lists#332
hgcummings wants to merge 2 commits into
gabehf:mainfrom
hgcummings:Exclusions

Conversation

@hgcummings

Copy link
Copy Markdown

Description

Allows excluding albums (or artists) from global "Top [entity]" lists and summaries, for example so seasonal artists/albums don't skew retrospectives.

Related Issue(s)

As discussed in #320

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Unit Tests
  • Manual Testing (please describe steps)

Have tested excluding albums and artists, then viewing global top artist/track/album pages and "rewind" pages.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have ensured my changes generate no new warnings

AI/LLM Usage

  • I disclose that ~50% of the code in this PR is written by an LLM, specifically:
  • ~90% of the CRUD for the new properties (which I've reviewed, and tweaked the UI)
  • ~50% of the tests (LLM wrote the first draft, which I've reviewed and rewritten)
  • ~0% of the query logic (written by me, with some review by an LLM)
  • I fully understand all changes made by LLM-generated code.
  • I have not and will not use an LLM to write any part of this PR description or PR comments.

Screenshots (if applicable)

image

@hgcummings

hgcummings commented Jul 25, 2026

Copy link
Copy Markdown
Author

Note: I haven't accounted for exclusions when calculating the rank for individual artist and album pages (https://github.com/gabehf/Koito/blob/main/internal/db/sqlite/artist.go#L90 and https://github.com/gabehf/Koito/blob/main/internal/db/sqlite/album.go#L104), i.e. albums/artists ranked lower than an excluded album/artist should arguably move up a place. I don't think the extra complexity serves any of the use cases described (which are about excluding niche artists/albums that will be ranked quite low anyway). Happy to do so though if you think it's worth it for the sake of consistency.

@hgcummings hgcummings changed the title Add option to exclude artists/albums from global top lists feat: add option to exclude artists/albums from global top lists Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant