feat: add option to exclude artists/albums from global top lists#332
Open
hgcummings wants to merge 2 commits into
Open
feat: add option to exclude artists/albums from global top lists#332hgcummings wants to merge 2 commits into
hgcummings wants to merge 2 commits into
Conversation
Author
|
Note: I haven't accounted for exclusions when calculating the rank for individual artist and album pages (https://github.com/gabehf/Koito/blob/main/internal/db/sqlite/artist.go#L90 and https://github.com/gabehf/Koito/blob/main/internal/db/sqlite/album.go#L104), i.e. albums/artists ranked lower than an excluded album/artist should arguably move up a place. I don't think the extra complexity serves any of the use cases described (which are about excluding niche artists/albums that will be ranked quite low anyway). Happy to do so though if you think it's worth it for the sake of consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows excluding albums (or artists) from global "Top [entity]" lists and summaries, for example so seasonal artists/albums don't skew retrospectives.
Related Issue(s)
As discussed in #320
Type of Change
How Has This Been Tested?
Have tested excluding albums and artists, then viewing global top artist/track/album pages and "rewind" pages.
Checklist
AI/LLM Usage
Screenshots (if applicable)