fix: split listenbrainz spotify artist credits - #323
Open
gbPagano wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ListenBrainz imports/submissions where Spotify-backed listens provide multiple artists only as a comma-separated
artist_nameplusspotify_artist_ids, withoutadditional_info.artist_names.Koito now infers separate artists only when the comma-split artist names match the number of Spotify artist IDs, avoiding cases like
Tyler, The Creator.Also fixes the fallback parsing of
mbid_mapping.artist_mbids.Related Issue(s)
N/A
Type of Change
How Has This Been Tested?
Manual test fixture was generated locally with ListenBrainz-style records such as
Pineapple StormTv, Sant, Tiago Mac,KVSH, Samhara, Lagum, and control cases likeTyler, The Creator.Checklist
AI/LLM Usage
Screenshots (if applicable)