Skip to content

feat: add axes and tooltip to interest over time graph#305

Open
joffrey-b wants to merge 2 commits into
gabehf:mainfrom
joffrey-b:improve-interest-graph
Open

feat: add axes and tooltip to interest over time graph#305
joffrey-b wants to merge 2 commits into
gabehf:mainfrom
joffrey-b:improve-interest-graph

Conversation

@joffrey-b

Copy link
Copy Markdown
Contributor

Description

The current graph for interest over time is a curve without information on the X and Y axes. This PR adds song listen count on the Y axis, and date to the X axis. The graph is already divided into 16 parts that adapt automatically regarding how long the song has been in the database for. This only adds the visual data.

The current implementation displays the dates using the browser's locale. If the PR for the date format is merged, this can also be adapted to follow what's set in the variable.

Related Issue(s)

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Unit Tests
  • Manual Testing (please describe steps)
  1. Check "interest over time" graph for tracks, albums, and artists.
  2. The graph should show on the Y axis the play count
  3. The graph should show on the X axis the dates
  4. Hover the mouse over the graph : it shows a tooltip for 16 parts of the graph
  5. The date range and listen counts automatically adapts to how long and how many times you've been listening to a song, artist, or album
  6. The date range and listen count in the tooltip also automatically adapts
  7. On a song that has no period of listening history (like for a song I listened to the first time today), the date in the tooltip shows a single date, not a range

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have ensured my changes generate no new warnings

AI/LLM Usage

  • I disclose that 100% of the code in this PR is written by an LLM. (please estimate)
  • I fully understand all changes made by LLM-generated code.
  • I have not and will not use an LLM to write any part of this PR description or PR comments.

Screenshots (if applicable)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant