Point people at the resource table from the top of both landing pages - #9
Merged
Conversation
The table is the fastest way into 653 things and it sat below a page of prose about where they came from. The prose still matters; it is not what someone arrives wanting. On the resources page, two buttons under the lede: search and filter all of them, or browse by topic for anyone who would rather read a curated page than work a filter. On the home page, a panel in the same shape as the portfolio one, above "where to start", naming a few publishers so the scale is concrete rather than a number on its own. The publisher count in that panel is computed, and computed as the sentence actually reads rather than as the easiest thing to count. My first attempt said "around 120", which was a guess. Replacing the guess with the distinct-domain count gave 121, which was still wrong twice: that total includes YouTube, Medium and LinkedIn, which host rather than publish, and it counts First Round twice because they have two domains. Excluding the platforms and the four publishers already named in the sentence gives 98, checked independently against resources.json.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe static-site build adds resource navigation CTAs, computes resource and publisher totals, and renders a homepage startup-resources panel. CSS provides spacing for the new inline CTA row. ChangesStartup resources experience
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table is the fastest way into 653 things and it sat below a page of prose about where they came from. The prose still matters; it is not what someone arrives wanting.
On the resources page, two buttons under the lede: search and filter all of them, or browse by topic for anyone who would rather read a curated page than work a filter. On the home page, a panel in the same shape as the portfolio one, above "where to start", naming a few publishers so the scale is concrete rather than a number on its own.
The publisher count in that panel is computed, and computed as the sentence actually reads rather than as the easiest thing to count. My first attempt said "around 120", which was a guess. Replacing the guess with the distinct-domain count gave 121, which was still wrong twice: that total includes YouTube, Medium and LinkedIn, which host rather than publish, and it counts First Round twice because they have two domains. Excluding the platforms and the four publishers already named in the sentence gives 98, checked independently against resources.json.
Summary by CodeRabbit
New Features
Style