Repository navigation
fix: improve comment removal - #604
Open
majestic-owl448 wants to merge 1 commit into
Open
majestic-owl448 wants to merge 1 commit into
majestic-owl448 wants to merge 1 commit into
Conversation
majestic-owl448
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Improve all four comment-removal helpers without adding dependencies. For example, Python floor division (
10 // 2) and comment markers inside strings are preserved, CSS empty comments are removed, HTML attribute values are preserved, and JavaScript block comments no longer merge tokens or erase meaningful line breaks.Add 62 regression cases, including 37 that fail on the original implementation. Update two existing JavaScript expectations to reflect non-nesting block comments and preserved line breaks.
This is a targeted improvement. JSX, JavaScript regex literals and template interpolations, Python f-string expressions, and HTML raw-text elements still require further work.
This is an improvement of the existing regex, before going to a parser, which usefulness need to be properly evaluated.