fix: targeted surveys will not be shown to anonymous users

[pandeymangg]

Fixes #27
Targeted surveys (surveys having segment filters) will not be shown to unidentified (anonymous) users

Summary by CodeRabbit

• Bug Fixes
  • Improved survey filtering to ensure only relevant surveys are shown when no user is logged in.
  • Surveys are now re-filtered immediately after logout to reflect the updated user state.

[coderabbitai]

Walkthrough

A new filtering step was added in SurveyManager.filterSurveys() to prevent surveys with segments (targeted surveys) from being shown to anonymous users. Additionally, UserManager.logout() now triggers a re-filtering of surveys after user state is cleared to ensure correct survey visibility upon logout.

Changes

Cohort / File(s)	Change Summary
Survey filtering for anonymous users Sources/FormbricksSDK/Manager/SurveyManager.swift	Added logic in filterSurveys() to exclude surveys with segments/filters for anonymous users.
Survey re-filtering on logout Sources/FormbricksSDK/Manager/UserManager.swift	Modified logout() to call surveyManager?.filterSurveys() after clearing user state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Prevent targeted surveys (with segments) from being shown to anonymous users (#27)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5bb2bf and 93ed5aa.

📒 Files selected for processing (2)

• Sources/FormbricksSDK/Manager/SurveyManager.swift (1 hunks)
• Sources/FormbricksSDK/Manager/UserManager.swift (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

Sources/FormbricksSDK/Manager/UserManager.swift (1)

Sources/FormbricksSDK/Manager/SurveyManager.swift (1)

• filterSurveys (39-72)

🔇 Additional comments (2)

Sources/FormbricksSDK/Manager/UserManager.swift (1)

142-143: LGTM! Proper integration with survey filtering.

The addition of surveyManager?.filterSurveys() after clearing user state ensures that surveys are correctly re-filtered for anonymous users upon logout, which is essential for preventing targeted surveys from being shown to logged-out users.

Sources/FormbricksSDK/Manager/SurveyManager.swift (1)

49-61: LGTM! Correctly implements anonymous user filtering for targeted surveys.

The filtering logic properly excludes surveys with segment filters for anonymous users while allowing:

• Surveys without segments (general surveys)
• Surveys with segments but empty filters (non-targeted segmented surveys)

This implementation aligns with the PR objective and ensures consistency with JavaScript and React Native SDKs.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/targeted-surveys-unidentified-users

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud