fix: branding text#24
Merged
Merged
Conversation
WalkthroughThe update modifies the initialization of the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new isBrandingEnabled flag to the WebViewData payload, allowing in-app survey branding to be toggled via the environment response (defaulting to true).
- Introduces
isBrandingEnabledin thedatadictionary, driven byenvironmentResponse.data.data.project.inAppSurveyBranding - Applies a default
truefallback when the backend value is missing
Comments suppressed due to low confidence (1)
Sources/FormbricksSDK/WebView/FormbricksViewModel.swift:101
- Add unit tests for
WebViewDatato verify thatisBrandingEnabledis correctly set wheninAppSurveyBrandingis true, false, or undefined.
data["isBrandingEnabled"] = environmentResponse.data.data.project.inAppSurveyBranding ?? true
mattinannt
approved these changes
Jun 11, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/formbricks/internal/issues/651
This pull request introduces a minor enhancement to the
WebViewDataclass inFormbricksViewModel.swift. The change adds a new key-value pair to thedatadictionary to support branding configuration for in-app surveys.Enhancement to branding configuration:
isBrandingEnabledto thedatadictionary, which determines whether in-app survey branding is enabled based on theenvironmentResponsedata. Defaults totrueif the value is not provided. (Sources/FormbricksSDK/WebView/FormbricksViewModel.swift, Sources/FormbricksSDK/WebView/FormbricksViewModel.swiftR101)Summary by CodeRabbit
Summary by CodeRabbit