Skip to content

fix(ci): explicitly trigger Maven release workflow from release-please#161

Open
KaviarasuSakthivadivel wants to merge 2 commits into
mainfrom
fix/ci-maven-release-trigger
Open

fix(ci): explicitly trigger Maven release workflow from release-please#161
KaviarasuSakthivadivel wants to merge 2 commits into
mainfrom
fix/ci-maven-release-trigger

Conversation

@KaviarasuSakthivadivel
Copy link
Copy Markdown
Contributor

GITHUB_TOKEN-triggered events don't cascade to prevent recursive workflows. When release-please creates a release using GITHUB_TOKEN, the 'release: published' event is suppressed and won't trigger the Maven Central publish workflow.

Solution: explicitly trigger release.yml via workflow_dispatch when a release is created.

Ref: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.10%. Comparing base (6081077) to head (892efa4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #161   +/-   ##
=========================================
  Coverage     83.10%   83.10%           
  Complexity     1667     1667           
=========================================
  Files           119      119           
  Lines          4641     4641           
  Branches        493      493           
=========================================
  Hits           3857     3857           
  Misses          560      560           
  Partials        224      224           
Components Coverage Δ
JDBC Core 84.10% <ø> (ø)
JDBC Main 40.69% <ø> (ø)
JDBC HTTP 90.30% <ø> (ø)
JDBC Utilities 65.25% <ø> (ø)
Spark Datasource ∅ <ø> (∅)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaviarasuSakthivadivel KaviarasuSakthivadivel force-pushed the fix/ci-maven-release-trigger branch from 0bda008 to 2f91cbb Compare March 6, 2026 19:56
@KaviarasuSakthivadivel KaviarasuSakthivadivel force-pushed the fix/ci-maven-release-trigger branch 2 times, most recently from 5094007 to 148ef5e Compare March 11, 2026 19:18
@KaviarasuSakthivadivel KaviarasuSakthivadivel force-pushed the fix/ci-maven-release-trigger branch from 148ef5e to 5ae281c Compare April 1, 2026 17:43
Copy link
Copy Markdown

@j10t j10t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. The wiring is correct end-to-end (verified release.yml has matching workflow_dispatch/tag_name input, release-please-action@v4 emits both outputs as named, no recursion risk).

One change before merge: the script: block interpolates ${{ needs.release-please.outputs.tag_name }} directly into inline JS, which is the pattern GitHub flags as script-injection-prone.

Comment thread .github/workflows/release-please.yml Outdated
KaviarasuSakthivadivel added a commit that referenced this pull request Apr 30, 2026
Move tag_name interpolation out of inline JS into an env var and read it
via process.env, matching the pattern already used in release.yml. Also
scope actions: write to the trigger-maven-release job instead of the
whole workflow so release-please runs with minimum privilege.

Addresses review feedback from @j10t on PR #161.
GITHUB_TOKEN-triggered events don't cascade to prevent recursive workflows.
When release-please creates a release using GITHUB_TOKEN, the 'release: published'
event is suppressed and won't trigger the Maven Central publish workflow.

Solution: explicitly trigger release.yml via workflow_dispatch when a release is created.

Ref: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
Move tag_name interpolation out of inline JS into an env var and read it
via process.env, matching the pattern already used in release.yml. Also
scope actions: write to the trigger-maven-release job instead of the
whole workflow so release-please runs with minimum privilege.

Addresses review feedback from @j10t on PR #161.
@KaviarasuSakthivadivel KaviarasuSakthivadivel force-pushed the fix/ci-maven-release-trigger branch from 209051e to 892efa4 Compare April 30, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants