adding my list page#5637
Open
SarkarKurdish wants to merge 2 commits into
Open
Conversation
Contributor
|
I'll have to look at this later, but I'm wondering, this is desktop only, right? I'm guessing there isn't any mobile support. |
Author
There is, in mobile view the bookmark button apears after all the icons (discord, …etc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using FMHY as a reference and kept losing track of links I meant to come back to.
How it works: when you hover a link on any wiki page, a small Bookmark button shows up next to it. Click it and that row gets saved to localStorage.
When rendering My List, the app tries to re-fetch the live row from the original page so you see the current version with tags and formatting intact. If an entry was removed from the wiki, it falls back to the HTML snapshot saved at bookmark time and marks it as removed. You can also remove items from My List with the X button.
There's a "My List" link at the top of the sidebar. Bookmark buttons don't show on the My List page itself (would be weird to bookmark bookmarks).
This is a draft and I'm definitely open to feedback, naming, UX, where the button appears, whether sidebar placement is right, performance of loading saved pages in the background, all of it. Happy to adjust before this is ready to merge.