Repository navigation
feat(charts): make the flyte-core executor replica count configurable - #8261
Merged
Merged
Conversation
The executor Deployment hard-coded replicas: 1. The executor already supports running more than one: reconcilers and the garbage collector run under controller-runtime leader election, replicas share the webhook cert Secret, and the secret service fans cache invalidation out to every pod through the headless Service. A standby replica takes over from a failed or rolling leader once its lease expires instead of waiting for a new pod to schedule and sync its caches. components.executor.replicaCount defaults to 1, and the chart refuses to render more than one without configuration.executor.leaderElect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dylan Jenkins <dylan.jenkins@ga.gov.au>
earlybard
marked this pull request as ready for review
October 28, 2026 02:56
Sovietaced
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The flyte-core executor Deployment hard-codes
replicas: 1, so the controller is a single point of failure: a node drain, OOM or rollout stalls every run until a new pod schedules and syncs its caches.The executor already copes with more than one replica, though. Reconcilers and the garbage collector run under controller-runtime leader election (
configuration.executor.leaderElect), replicas adopt one shared webhook cert Secret, and the secret service fans cache invalidation out to every pod through the headless Service. The chart just doesn't let you ask for a second one.What changes were proposed in this pull request?
components.executor.replicaCount, defaulting to 1.configuration.executor.leaderElectis on, since without it the replicas would reconcile the same TaskActions twice.How was this patch tested?
helm lint, andhelm templatefor the default, for 2 replicas without leader election (render fails) and for 2 with it. I also ran two replicas with leader election on our EKS cluster and deleted the leader partway through a fan-out run. The standby took the lease 17s later, and the run went on to launch its second wave and finish.Labels
Check all the applicable boxes
AI disclosure: written with Claude Code as a code assistant, reviewed by me.