Repository navigation
Add metrics + tracing for Postgres with otelsql - #8257
Merged
Merged
Conversation
Sovietaced
force-pushed
the
otel-sql
branch
3 times, most recently
from
October 27, 2026 20:06
024829c to
c1a8913
Compare
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
changed the title
Sovietaced
commented
Oct 27, 2026
| // RegisterProvidersWithContext registers tracer and metric providers for the service. | ||
| // If already registered, the existing providers are reused. | ||
| func RegisterProvidersWithContext(ctx context.Context, serviceName string, config *Config) error { | ||
| if tracerProviders[serviceName] != nil && meterProviders[serviceName] != nil { |
Member
Author
There was a problem hiding this comment.
Added this because sometimes the DB OTEL is setup before the Redis OTEL of services. This gracefully handled duplicate registration.
Sovietaced
marked this pull request as ready for review
October 27, 2026 20:29
pingsutw
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
I am performing scale testing of Flyte 2 and find metrics and tracing very helpful to debug performance issues. These metrics may also be helpful for users that wants to create alerts.
What changes were proposed in this pull request?
Add support for metrics + tracing with the
otelsqllibrary.How was this patch tested?
Tested in our internal fork.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link