Repository navigation
refactor(idl): remove unused queue timing reservations - #8253
Merged
Merged
Conversation
Address review feedback on #8229: the discarded enqueue timestamp field never shipped and does not need a reservation. Keep every active field unchanged, including worker_assigned_at at field 9, and regenerate the affected descriptors. Signed-off-by: Carina Ursu <carina@union.ai>
EngHabu
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Follow-up to #8229.
Why are the changes needed?
The discarded
queue_wait_started_atfield was never part of a shipped API, so its reservation is unnecessary. This addresses Haytham's review comment after #8229 merged.What changes were proposed in this pull request?
Remove the unused field-8/name reservations and their rationale comment from
ActionStatus, and regenerate the affected Go, Python, Rust, and TypeScript descriptors. Every active field keeps its existing number and type, includingqueued_at = 7andworker_assigned_at = 9.Most changed lines are generated descriptor bytes. The source change removes four lines.
How was this patch tested?
buf format --diff --exit-codeandbuf lint --exclude-path flytestdlib/pass.go test ./gen/go/flyteidl2/workflow/... ./runs/service ./runs/testclientandgo vet ./runs/service ./runs/testclientpass.npx tsc --noEmit.origin/mainconfirms the only schema differences are the requested reservations; every active field is identical. TypeScript/Python binary and JSON round-trips preserve the timestamp fields and their exact serialized bytes, including assignment field 9. Unknown timestamps remain omitted.buf breaking --against '.git#ref=origin/main' --exclude-path flytestdlib/reports exactly the two intentionalRESERVED_MESSAGE_NO_DELETEfindings for this requested cleanup. No breaking-check configuration was changed.No application behavior or active protobuf fields change, so no new application tests were added. The local checks above passed; full CI is pending, including Rust crate compilation.
Check all the applicable boxes
Related PRs