Repository navigation
rend: clamp xBRZ texture upscale factor to 2..6 - #2545
Merged
flyinghead merged 1 commit intoOct 16, 2026
Merged
Conversation
xbrz::scale() only implements factors 2 to 6. Any other value hits an assert that's compiled out in release builds, and scale() returns without writing the destination buffer. The texture is then uploaded from uninitialized memory at the requested size. rend.TextureUpscale2 can be set to 8 or 16 through emu.cfg or Lua. Clamp the factor once and use it for the buffer size, the scale call and the upscaled dimensions so they always agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xbrz::scale() only implements factors 2 to 6. Any other value hits an
assert that's compiled out in release builds, and scale() returns
without writing the destination buffer. The texture is then uploaded
from uninitialized memory at the requested size.
rend.TextureUpscale2 can be set to 8 or 16 through emu.cfg or Lua.
Clamp the factor once and use it for the buffer size, the scale call
and the upscaled dimensions so they always agree.
Testing: compiles in the libretro core and the standalone build (macOS arm64). Not run on content.
🤖 Generated with Claude Code