feat(framework): Allow TLS for flwr-model#7366
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables TLS support for the flwr-model process by wiring CLI TLS flags through to the gRPC channel creation used to connect to SuperLink’s ServerAppIo API.
Changes:
- Forward
--insecureand resolved root certificates fromflwr-modelCLI into the model task runtime. - Update model task gRPC stub creation to use an explicit
insecureflag (instead of inferring it from certificate presence). - Adjust CLI wiring tests to include/verify the new
insecureargument forwarding.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| framework/py/flwr/supercore/task_process/model/run_model.py | Accepts insecure and uses it when creating the ServerAppIo gRPC channel. |
| framework/py/flwr/supercore/cli/flwr_model.py | Removes TLS-not-supported guard and resolves/passes root certificates for TLS connections. |
| framework/py/flwr/supercore/cli/flwr_model_test.py | Updates CLI forwarding test inputs/assertions for the new TLS-related args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danieljanes
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?