Skip to content

feat(framework): Allow TLS for flwr-model#7366

Merged
danieljanes merged 3 commits into
mainfrom
update-flwr-model
Jun 16, 2026
Merged

feat(framework): Allow TLS for flwr-model#7366
danieljanes merged 3 commits into
mainfrom
update-flwr-model

Conversation

@danielnugraha

Copy link
Copy Markdown
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Address LLM-reviewer comments, if applicable (e.g., GitHub Copilot)
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

Copilot AI review requested due to automatic review settings June 12, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables TLS support for the flwr-model process by wiring CLI TLS flags through to the gRPC channel creation used to connect to SuperLink’s ServerAppIo API.

Changes:

  • Forward --insecure and resolved root certificates from flwr-model CLI into the model task runtime.
  • Update model task gRPC stub creation to use an explicit insecure flag (instead of inferring it from certificate presence).
  • Adjust CLI wiring tests to include/verify the new insecure argument forwarding.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
framework/py/flwr/supercore/task_process/model/run_model.py Accepts insecure and uses it when creating the ServerAppIo gRPC channel.
framework/py/flwr/supercore/cli/flwr_model.py Removes TLS-not-supported guard and resolves/passes root certificates for TLS connections.
framework/py/flwr/supercore/cli/flwr_model_test.py Updates CLI forwarding test inputs/assertions for the new TLS-related args.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/py/flwr/supercore/task_process/model/run_model.py
Comment thread framework/py/flwr/supercore/cli/flwr_model.py
@github-actions github-actions Bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Jun 12, 2026

@panh99 panh99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes enabled auto-merge (squash) June 16, 2026 13:41
@danieljanes danieljanes merged commit 6a4732e into main Jun 16, 2026
61 checks passed
@danieljanes danieljanes deleted the update-flwr-model branch June 16, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants