refactor(framework): Refactor model task messages#7341
Open
danielnugraha wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors typed “model task messages” by moving them into a dedicated flwr.supercore.task_message package, introducing shared utilities/validation, and updating internal imports to the new module path.
Changes:
- Introduces
TaskMessagebase class plus shared payload serialization helpers/constants underflwr.supercore.task_message. - Re-implements
ModelRequest/ModelResponseon top ofTaskMessagewith centralized validation helpers. - Updates task-process code and tests to import model task messages from the new location and removes the old
flwr.supercore.model_messagemodule.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/py/flwr/supercore/task_process/model/task.py | Updates import to new task_message.model_message location. |
| framework/py/flwr/supercore/task_process/agent/session.py | Updates import to new task_message.model_message location. |
| framework/py/flwr/supercore/task_message/validation.py | Adds reusable validation helpers for task message JSON payloads. |
| framework/py/flwr/supercore/task_message/utils.py | Adds shared payload <-> message content serialization helpers. |
| framework/py/flwr/supercore/task_message/model_message.py | Adds ModelRequest/ModelResponse implemented on top of TaskMessage. |
| framework/py/flwr/supercore/task_message/model_message_test.py | Updates tests to import from the new module path. |
| framework/py/flwr/supercore/task_message/constant.py | Adds constants for payload keys and default TTL. |
| framework/py/flwr/supercore/task_message/base.py | Adds TaskMessage base class and typed parsing helper. |
| framework/py/flwr/supercore/task_message/init.py | Introduces new package marker/docstring. |
| framework/py/flwr/supercore/model_message.py | Removes the previous monolithic implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?