Clean up benchmarks and add search benchmarks#2533
Merged
Conversation
EagleoutIce
approved these changes
Jun 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR streamlines the project’s Vitest benchmark setup by removing an older slicing benchmark file, introducing new search-focused benchmarks, and documenting a dedicated npm script to run benchmarks.
Changes:
- Removed the legacy slicing benchmark file.
- Added a new
flowR searchbenchmark suite and a helper (benchmarkSearch) to benchmark search queries. - Added
npm run test:benchand updated documentation to reference it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functionality/slicing/slicing.bench.ts | Removes the previous slicing benchmark file. |
| test/functionality/search/search.bench.ts | Adds benchmarks for search filters/enrichments and a larger “function finder” scenario. |
| test/functionality/_helper/search.ts | Adds benchmarkSearch helper used by the new benchmark suite. |
| src/documentation/wiki-linting-and-testing.ts | Updates docs to point users to npm run test:bench. |
| package.json | Adds test:bench script (vitest bench --config test/vitest.config.mts). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
This pull request is included in v2.10.8 (see Release v2.10.8 (MultiValue fixes, refined input sources, fixed linter rules)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.