Skip to content

Clean up benchmarks and add search benchmarks#2533

Merged
EagleoutIce merged 6 commits into
mainfrom
search-bench
Jun 8, 2026
Merged

Clean up benchmarks and add search benchmarks#2533
EagleoutIce merged 6 commits into
mainfrom
search-bench

Conversation

@Ellpeck

@Ellpeck Ellpeck commented Jun 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@Ellpeck Ellpeck marked this pull request as ready for review June 3, 2026 12:40
@Ellpeck Ellpeck requested a review from EagleoutIce June 3, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the project’s Vitest benchmark setup by removing an older slicing benchmark file, introducing new search-focused benchmarks, and documenting a dedicated npm script to run benchmarks.

Changes:

  • Removed the legacy slicing benchmark file.
  • Added a new flowR search benchmark suite and a helper (benchmarkSearch) to benchmark search queries.
  • Added npm run test:bench and updated documentation to reference it.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/functionality/slicing/slicing.bench.ts Removes the previous slicing benchmark file.
test/functionality/search/search.bench.ts Adds benchmarks for search filters/enrichments and a larger “function finder” scenario.
test/functionality/_helper/search.ts Adds benchmarkSearch helper used by the new benchmark suite.
src/documentation/wiki-linting-and-testing.ts Updates docs to point users to npm run test:bench.
package.json Adds test:bench script (vitest bench --config test/vitest.config.mts).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/functionality/_helper/search.ts
Comment thread test/functionality/search/search.bench.ts
@Ellpeck Ellpeck requested a review from EagleoutIce June 8, 2026 12:17
@EagleoutIce EagleoutIce merged commit dc45109 into main Jun 8, 2026
19 checks passed
@EagleoutIce EagleoutIce deleted the search-bench branch June 8, 2026 13:54
@EagleoutIce

Copy link
Copy Markdown
Member

This pull request is included in v2.10.8 (see Release v2.10.8 (MultiValue fixes, refined input sources, fixed linter rules)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants