Trigger on Packages with Known Information#2472
Open
EagleoutIce wants to merge 13 commits into
Open
Conversation
a call to importFrom does now not lead to adding all imports of the dependency that is imported by this call as well anymore but only adds the specified functions; namespace_env is now not added anymore, instead the imports_env is added as the parent of the package_env
new env structure: namespace -> imports -> globalEnv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still open:
x <- "foo"; library(x, character.only = TRUE)should recognize that we loadfooand notx, likewise with thelapplyetc. pattern)importetc. (import(grid)); but we have to check whether already loadedexportPattern...In the future, we want to include the information and we have to respect versions.