Add Adobe Acrobat Pro as a Windows FMA#43829
Draft
allenhouchins wants to merge 4 commits intomainfrom
Draft
Conversation
Add Winget support for Adobe Acrobat Pro: new input JSON, install/uninstall PowerShell scripts, and Windows output manifest (with script refs and installer metadata). Rename Homebrew input and apps listing to "Adobe Acrobat Pro" and add a Windows entry to apps.json. Improve winget ingester to try version directories in descending order, skip grouping dirs that don't contain expected manifests, fetch and unmarshal installer and locale manifests with better logging and error handling, and return a clear error when no valid version manifest is found.
fleet-release
previously approved these changes
Apr 21, 2026
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Rename the unique_identifier from 'Adobe Acrobat (64-bit)' to 'Adobe Acrobat DC (64-bit)'. Update the Windows detection SQL queries to match the new name so existence and patched checks work correctly. Affected files: ee/maintained-apps/inputs/winget/adobe-acrobat-pro.json, ee/maintained-apps/outputs/adobe-acrobat-pro/windows.json, ee/maintained-apps/outputs/apps.json.
fleet-release
previously approved these changes
Apr 21, 2026
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43829 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 2601 2601
Lines 208982 209001 +19
Branches 9305 9305
=======================================
+ Hits 139842 139856 +14
- Misses 56398 56402 +4
- Partials 12742 12743 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Make Acrobat uninstaller detection more robust and update metadata to the new script ref. app_commander.go: clarify the error log when an app remains after uninstall. adobe_acrobat_pro_uninstall.ps1: support both "Adobe Acrobat (64-bit)" and "Adobe Acrobat DC (64-bit)", guard against missing DisplayName, and ensure publisher filtering is applied before matching. windows.json: bump uninstall_script_ref to c94fe3ab and replace the embedded ref with the updated uninstall script.
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Contributor
Script Diff Resultsee/maintained-apps/outputs/adobe-acrobat-pro/windows.json=== Install Script (no changes) ===
=== Uninstall // 96f53707 -> c94fe3ab ===
--- /tmp/old.KzzCYS 2026-04-21 03:10:28.351368440 +0000
+++ /tmp/new.P2JPc6 2026-04-21 03:10:28.352368442 +0000
@@ -1,6 +1,7 @@
-# Locate Adobe Acrobat Pro uninstaller from registry and execute it silently
+# Locate Adobe Acrobat Pro uninstaller from registry and execute it silently.
+# DisplayName is "Adobe Acrobat DC (64-bit)" on DC installs and may be "Adobe Acrobat (64-bit)" on others.
-$displayName = "Adobe Acrobat (64-bit)"
+$displayNames = @("Adobe Acrobat (64-bit)", "Adobe Acrobat DC (64-bit)")
$publisher = "Adobe"
$paths = @(
@@ -12,7 +13,13 @@
$uninstall = $null
foreach ($p in $paths) {
$items = Get-ItemProperty "$p\*" -ErrorAction SilentlyContinue | Where-Object {
- $_.DisplayName -and ($_.DisplayName -eq $displayName -or $_.DisplayName -like "$displayName*") -and ($publisher -eq "" -or $_.Publisher -eq $publisher)
+ $dn = $_.DisplayName
+ if (-not $dn) { return $false }
+ if ($publisher -ne "" -and $_.Publisher -ne $publisher) { return $false }
+ foreach ($d in $displayNames) {
+ if ($dn -eq $d -or $dn -like "$d*") { return $true }
+ }
+ $false
}
if ($items) { $uninstall = $items | Select-Object -First 1; break }
} |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Winget support for Adobe Acrobat Pro: new input JSON, install/uninstall PowerShell scripts, and Windows output manifest (with script refs and installer metadata). Rename Homebrew input and apps listing to "Adobe Acrobat Pro" and add a Windows entry to apps.json. Improve winget ingester to try version directories in descending order, skip grouping dirs that don't contain expected manifests, fetch and unmarshal installer and locale manifests with better logging and error handling, and return a clear error when no valid version manifest is found.