Skip to content

[addon-operator] use shell-operator as a lib#770

Draft
fuldaxxx wants to merge 2 commits into
mainfrom
feat/use-shell-operator-as-lib
Draft

[addon-operator] use shell-operator as a lib#770
fuldaxxx wants to merge 2 commits into
mainfrom
feat/use-shell-operator-as-lib

Conversation

@fuldaxxx
Copy link
Copy Markdown
Member

@fuldaxxx fuldaxxx commented May 29, 2026

Overview

This PR updates addon-operator integration with shell-operator to the new library-oriented flow and removes reliance on shell-operator app globals for debug socket wiring.

What this PR does / why we need it

  • bumps github.com/flant/shell-operator;
  • switches engine creation to shell_operator.NewBareShellOperator(...) with explicit options;
  • keeps shell-operator debug commands (queue/config/hook/raw) aligned with addon-operator socket by setting debug.DefaultSocketPath = cfg.Debug.UnixSocket (both in main.go and
    NewAddonOperator);
  • keeps config projection via ShellOperatorConfig(...) for AssembleCommonOperatorFromConfig(...);
  • updates shutdown path to context-based graceful shutdown with timeout and error logging;
  • refreshes tests to validate new debug socket contract via debug.DefaultSocketPath

fuldaxxx added 2 commits May 29, 2026 10:37
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
@fuldaxxx fuldaxxx self-assigned this May 29, 2026
@fuldaxxx fuldaxxx added the go Pull requests that update Go code label May 29, 2026
@fuldaxxx fuldaxxx requested review from ipaqsa and ldmonster May 29, 2026 11:57
@fuldaxxx fuldaxxx changed the title chore: switch shell-operator debug socket sync to default path [addon-operator] use shell-operator as a lib May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant