feat(fixtures): add repeated metric comparisons - #85
Draft
adityathebe wants to merge 4 commits into
Draft
Conversation
Fixture matrices need repeated command observations and numeric regression checks without inflating logical row counts. Run samples serially under one row timeout, retain per-sample command, CEL, and metric evidence, and finalize generic aggregates, thresholds, and baseline comparisons after all rows complete. Preserve the legacy single-run path and omit additive fields for existing fixtures. Amp-Thread-ID: https://ampcode.com/threads/T-01a0397c-0e63-731f-b7f4-84ab67aeac1a
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Gavel summary
Totals: 2517 passed · 0 failed · 18 skipped · 5m33s |
Contributor
Gavel summary
Totals: 0 passed · 0 failed · 0 skipped · - |
PTY startup failures left a zero exit code, so command expectations could incorrectly pass. Derived metric arithmetic could also store infinities and make JSON reporting fail. Mark failed PTY starts with a negative exit code, scale mean and even-median aggregation, and reject non-finite aggregate or regression results before storing them.
The PTY cancellation callback used syscall.Kill from an untagged file, preventing the exec fixture type from compiling on Windows. Keep Unix process-group cancellation in a Unix-only helper and use os.Process.Kill on other platforms. Amp-Thread-ID: https://ampcode.com/threads/T-01a0397c-0e63-731f-b7f4-84ab67aeac1a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test ./fixtures/...go vet ./fixtures/...GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false go test ./cmd/gavelgo build ./cmd/gavelRepository-wide caveats
A raw
go test ./...is not green in this orb because its global Git config references a transient missing SSH signing buffer, history/date tests run against a shallow checkout whose newest commit predates their query window, andtestrunner/uiexpects an unavailablegoogle-chromeexecutable. Signing-dependentcmd/gavel,commit, andtodos/claudechecks pass with the one-command signing override above; the affected fixture packages pass normally.Closes #84