Skip to content

feat(docs): add mobile-toc option to docs.yml layout config#15049

Open
matlegault wants to merge 1 commit intomainfrom
matlegault/docs-mobile-toc-config
Open

feat(docs): add mobile-toc option to docs.yml layout config#15049
matlegault wants to merge 1 commit intomainfrom
matlegault/docs-mobile-toc-config

Conversation

@matlegault
Copy link
Copy Markdown
Contributor

@matlegault matlegault commented Apr 15, 2026

Summary

Changes Made

  • Added mobile-toc: optional<boolean> to LayoutConfig in the Fern API definition
  • Added mobile-toc to the zod schema in DocsYmlSchemas.ts
  • Added mobileToc to the API type interface and serialization layer
  • Mapped mobileToc in parseDocsConfiguration.ts (defaults to false)
  • Updated both JSON schema files with the new field

Test plan

  • Verify layout: { mobile-toc: true } in docs.yml is parsed correctly
  • Verify the field flows through to the write shape as mobileToc: true
  • Verify omitting the field defaults to false

🤖 Generated with Claude Code

Add opt-in `mobile-toc` boolean to the layout section of docs.yml,
enabling a sticky collapsible table of contents bar on mobile viewports
for guide and overview layout pages.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matlegault matlegault self-assigned this Apr 15, 2026
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@github-actions
Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-15T04:55:58Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
csharp-sdk square 93s 137s 95s +2s (+2.2%)
go-sdk square 104s 142s 105s +1s (+1.0%)
java-sdk square 160s 188s 157s -3s (-1.9%)
php-sdk square 85s 116s 87s +2s (+2.4%)
python-sdk square 111s 146s 114s +3s (+2.7%)
ruby-sdk-v2 square 115s 154s 118s +3s (+2.6%)
rust-sdk square 99s 92s 94s -5s (-5.1%)
swift-sdk square 84s 124s 76s -8s (-9.5%)
ts-sdk square 100s 143s 104s +4s (+4.0%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-15T04:55:58Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-04-15 16:30 UTC

@github-actions
Copy link
Copy Markdown
Contributor

Docs Generation Benchmark Results

Comparing PR branch against main baseline.

Fixture main PR Delta
docs N/A 312.1s (35 versions) N/A

Docs generation runs fern generate --docs --preview end-to-end against the benchmark fixture with 35 API versions (each version: markdown processing + OpenAPI-to-IR + FDR upload).
Delta is computed against the nightly baseline on main.
Last updated: 2026-04-15 16:32 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant