feat: add drop parameter to OneHotEncoder (#913)#928
Open
BALOGUN-DAVID wants to merge 2 commits into
Open
Conversation
Author
|
Hi @solegalli, it's me again! 👋 I've pushed the fixes and the PR is now ready for your review. This adds the Let me know if you need any adjustments or if this is good to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #913
Description
This PR adds a
dropparameter to theOneHotEncoderto allow users to control which dummy category is dropped when performing k-1 encoding. Previously, only the last category in the unique insertion order could be dropped viadrop_last=True.New
dropstrategies:'last': Drops the last category in alphabetical order.'first': Drops the first category in alphabetical order.'most_frequent': Drops the most frequent category found duringfit(). In the event of a tie, aUserWarningis raised and the first category alphabetically among the ties is dropped.Backward Compatibility:
The
drop_lastparameter is fully preserved for backward compatibility. If bothdrop_lastanddropare specified,droptakes precedence and aFutureWarningis emitted.Checklist
dropparameter and implementation logicFutureWarningwhen bothdropanddrop_lastare setdropstrategies and tie-breaking