Repository navigation
Add native boot menu settings for installed drives - #1
Merged
Merged
Conversation
Ventoy honours only the first key of each object in the control array, so edits are now normalised to one key per object; previously a save could reorder a multi-key object and silently change which setting took effect. Negative timeouts load as "wait for selection" instead of being rejected. Unsupported layouts and unmounted data partitions get their own messages rather than a "reconnect the drive" prompt. JSON syntax errors surface as the sheet's own invalid-document message. The sheet keeps Cancel enabled while loading, attaches the image picker as a sheet so the parent cannot be dismissed underneath it, compares the search root case-insensitively, and tracks dirty state through a single Equatable value. The config test now runs in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native Boot Menu sheet for installed drives: list/folder menu style, optional automatic boot with a delay, and a default-image file picker restricted to the selected data volume. Changes are saved explicitly to
/ventoy/ventoy.jsonusing normal user permissions.Only edited global controls are changed. Other plugins, unknown controls and firmware-specific settings are preserved. Turning automatic boot off removes the timeout; existing malformed configurations and stale saves are refused. The data volume is resolved by partition identity and its mount path/UUID are checked again before saving.
This is a deliberately small first configuration contribution. It does not change the installer or add a theme editor. Firmware-specific overrides remain outside this sheet and are called out when present.
UI
Verification
make app: arm64 and x86_64 builds pass (local builds unsigned).make test-config: save/reopen, timeout removal, preservation of plugins and multi-mode controls, stale-save rejection, malformed controls and symlink rejection pass.Control semantics follow Ventoy's global control documentation.