fix(ios): latch clipping container to prevent overflow-toggle crash on mounted views#29
Open
aljadan wants to merge 1 commit into
Open
fix(ios): latch clipping container to prevent overflow-toggle crash on mounted views#29aljadan wants to merge 1 commit into
aljadan wants to merge 1 commit into
Conversation
aljadan
commented
Jun 28, 2026
| if (_props->getClipsContentToBounds()) { | ||
| _forcesClippingContainer = YES; | ||
| } | ||
| return _forcesClippingContainer || [super styleWouldClipOverflowInk]; |
Author
There was a problem hiding this comment.
we could just always return true, but then every squircle gets a backing UIView even when it never clips (not great for perf)
the latch flips on the first time we actually clip and then just stays put so it doesn't toggle while mounted
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #28