Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

No checks are performed for missing TOML sections #70

Description

@minus27

No checks are performed for missing TOML sections

Overview

  1. OS name and version.
    N/A
  2. go version output
    N/A
  3. waflyctl --version in recent releases or brew info waflyctl output.

Fastly WAF Control Tool version: 0.2.1 built on 2018-11-09T16:21:56Z by #team-soc

  1. Description of the problem. What is happening that shouldn't?
    I did not want to create any logging endpoints and commented out the [weblogs] and [waflogs] sections. waflyctl tried to create the logging endpoints with the default object values and an error resulted. (See below)
  2. Description of the expected behaviour.
    If no logging endpoint configuration information is provided, I would have like waflyctl to skip the creation of a logging endpoint altogether.
  3. Exact steps to reproduce the error.
    Delete or comment out the [weblogs] and [waflogs] sections of a toml file and run waflyctl.

Additional Information:

  1. Logs showing errors or behaviour.

400 - Bad Request:

Title: Bad request
Detail: Need either 'ipv4' or 'ipv6' or 'hostname'ERROR: 2018/12/20 15:42:26 waflyctl.go:967: Fatal issue creating logging settings..`

  1. Steps which have been taken to try address the issue.
    I ended up putting the [weblogs] and [waflogs] sections of a toml file back with minimal values and ran into another problem, which will be documented in a separate issue.
  2. Other data which indicates what may be causing the issue.
    N/A
  3. Stack trace if any error is seen.
    N/A

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions