Long time no sync#268
Closed
wz337 wants to merge 1 commit into
Closed
Conversation
Summary: Re-sync of distributed_shampoo + gpa dev source to OSS (facebookresearch/optimizers), regenerated via oss_sync.sh on top of the CI fixes in the parent diff. Supersedes the prior sync (D112246130), which was red. The two failures on the prior sync are fixed by the parent diff and included here: - gpu-tests: train_model now relocates pre-generated data onto the model's device (fixes 114 "tensors on different device" errors). - pre-commit: recompilation-test license merged into its docstring (fixes ruff E402 x16 caused by the sync prepending a second license docstring). Validated locally against the OSS venv on H100: - ruff check distributed_shampoo: all checks passed - gpu_tests via torchrun --nproc_per_node=2: Ran 258 tests, OK (was 114 errors) - weight_decay_test: Ran 80 tests, OK - mypy: Success, no issues in 95 source files Differential Revision: D112398609
meta-cla
Bot
added
the
CLA Signed
|
@wz337 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112398609. |
|
This pull request has been merged in 5b6bd7e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Re-sync of distributed_shampoo + gpa dev source to OSS
(facebookresearch/optimizers), regenerated via oss_sync.sh on top of the CI
fixes in the parent diff. Supersedes the prior sync (D112246130), which was red.
The two failures on the prior sync are fixed by the parent diff and included here:
(fixes 114 "tensors on different device" errors).
E402 x16 caused by the sync prepending a second license docstring).
Validated locally against the OSS venv on H100:
Differential Revision: D112398609