Remove deprecated argument use_update to GenerationStep (#5187)#5187
Closed
esantorella wants to merge 1 commit intofacebook:mainfrom
Closed
Remove deprecated argument use_update to GenerationStep (#5187)#5187esantorella wants to merge 1 commit intofacebook:mainfrom
use_update to GenerationStep (#5187)#5187esantorella wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101822874. |
meta-codesync
Bot
changed the title
use_update to GenerationStepuse_update to GenerationStep (#5187)
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 21, 2026
…#5187) Summary: **Context**: * This was deprecated in 2023. * It was actually hard-deprecated because we had `raise DeprecationWarning` (an exception). * It does not do anything, so it is safe to remove. **This PR**: * Removes places where the argument is passed * Does not remove it from a storage backward-compatibility test Differential Revision: D101822874
esantorella
force-pushed
the
export-D101822874
branch
from
0bbe0eb to
b8279c1
Compare
…#5187) Summary: Pull Request resolved: facebook#5187 **Context**: * This was deprecated in 2023. * It was actually hard-deprecated because we had `raise DeprecationWarning` (an exception). * It does not do anything, so it is safe to remove. **This PR**: * Removes places where the argument is passed * Does not remove it from a storage backward-compatibility test Differential Revision: D101822874
esantorella
force-pushed
the
export-D101822874
branch
from
b8279c1 to
9e9cd77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5187 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 619 619
Lines 69293 69291 -2
=======================================
- Hits 66818 66817 -1
+ Misses 2475 2474 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in a415d77. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
raise DeprecationWarning(an exception).This PR:
Differential Revision: D101822874