Skip to content

fix(macro)!: argument metadata from the type, not from its spelling - #790

Merged
ptondereau merged 9 commits into
masterfrom
fix/dx1-arg-metadata-from-traits
Sep 22, 2026
Merged

ptondereau merged 9 commits into
masterfrom
fix/dx1-arg-metadata-from-traits

Conversation

@ptondereau

@ptondereau ptondereau commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Description

Argument nullability, pass-by-reference and variadics now come from constants on FromZval/FromZvalMut instead of matching type names, so aliases and qualified paths get the right PHP signature.

Object arguments are passed by value, optional nullable arguments declare a null default, and Default/Clone are detected through the type system.

Checklist

@codspeed

codspeed Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing fix/dx1-arg-metadata-from-traits (51d2af0) with master (a8d5d9c)

Open in CodSpeed

@coveralls

coveralls commented Sep 22, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 35765197921

Coverage increased (+0.08%) to 69.628%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 38 uncovered changes across 4 files (259 of 297 lines covered, 87.21%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/internal/class.rs 18 0 0.0%
src/convert.rs 78 68 87.18%
src/types/array/mod.rs 6 0 0.0%
src/args.rs 68 64 94.12%
Total (7 files) 297 259 87.21%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13891
Covered Lines: 9672
Line Coverage: 69.63%
Coverage Strength: 54.77 hits per line

💛 - Coveralls

@ptondereau
ptondereau marked this pull request as ready for review September 22, 2026 18:34
@ptondereau
ptondereau merged commit b8978a1 into master Sep 22, 2026
72 checks passed
@ptondereau
ptondereau deleted the fix/dx1-arg-metadata-from-traits branch September 22, 2026 18:36
@Xenira Xenira mentioned this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants