Skip to content

fix(macro)!: consistent getter/setter property naming and order - #789

Merged
ptondereau merged 5 commits into
masterfrom
fix/dx1b-property-naming-order
Sep 21, 2026
Merged

ptondereau merged 5 commits into
masterfrom
fix/dx1b-property-naming-order

Conversation

@ptondereau

Copy link
Copy Markdown
Member

Description

Getter/setter properties now follow the field naming rule (camelCase, name/change_case honoured), are declared in source order, and conflicting getter/setter declarations or a field/method name collision are errors instead of silent picks. PropertyDescriptor::mangled_name is gone: every mangled name is computed at runtime, which fixes get_properties for non-literal flags expressions.

Checklist

@coveralls

coveralls commented Sep 20, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 35575985860

Coverage increased (+0.1%) to 69.553%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 15 uncovered changes across 4 files (88 of 103 lines covered, 85.44%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
crates/macros/src/impl_.rs 59 54 91.53%
src/class.rs 4 0 0.0%
src/builders/class.rs 37 34 91.89%
src/zend/handlers.rs 3 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13952
Covered Lines: 9704
Line Coverage: 69.55%
Coverage Strength: 52.66 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing fix/dx1b-property-naming-order (684c955) with master (a25eb73)

Open in CodSpeed

@ptondereau
ptondereau force-pushed the fix/dx1b-property-naming-order branch 2 times, most recently from b656ab7 to b9e546a Compare September 20, 2026 18:22
@ptondereau
ptondereau force-pushed the fix/dx1b-property-naming-order branch from b9e546a to 684c955 Compare September 21, 2026 08:04
@ptondereau
ptondereau marked this pull request as ready for review September 21, 2026 08:22
@ptondereau
ptondereau merged commit a8d5d9c into master Sep 21, 2026
72 checks passed
@ptondereau
ptondereau deleted the fix/dx1b-property-naming-order branch September 21, 2026 08:26
@Xenira Xenira mentioned this pull request Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants