fix(macro)!: consistent getter/setter property naming and order - #789
Merged
Merged
Conversation
Coverage Report for CI Build 35575985860Coverage increased (+0.1%) to 69.553%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ptondereau
force-pushed
the
fix/dx1b-property-naming-order
branch
2 times, most recently
from
September 20, 2026 18:22
b656ab7 to
b9e546a
Compare
ptondereau
force-pushed
the
fix/dx1b-property-naming-order
branch
from
September 21, 2026 08:04
b9e546a to
684c955
Compare
ptondereau
marked this pull request as ready for review
September 21, 2026 08:22
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Getter/setter properties now follow the field naming rule (camelCase,
name/change_casehonoured), are declared in source order, and conflicting getter/setter declarations or a field/method name collision are errors instead of silent picks.PropertyDescriptor::mangled_nameis gone: every mangled name is computed at runtime, which fixesget_propertiesfor non-literalflagsexpressions.Checklist