Skip to content

fix(macro)!: no silently ignored macro attribute - #788

Merged
ptondereau merged 6 commits into
masterfrom
fix/macro-silent-attributes
Sep 20, 2026
Merged

ptondereau merged 6 commits into
masterfrom
fix/macro-silent-attributes

Conversation

@ptondereau

Copy link
Copy Markdown
Member

Description

Macro options and arguments that parsed and then did nothing are now compile errors that point at the offending token, and class constants inside #[php_impl] accept #[php(vis = ...)]. The migration guide lists each removed option and the new ConstantFlags parameter on ClassBuilder.

Checklist

@ptondereau
ptondereau force-pushed the fix/macro-silent-attributes branch from f9a827d to a22bbb6 Compare September 20, 2026 17:14
@coveralls

coveralls commented Sep 20, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 35525251129

Coverage decreased (-0.04%) to 69.448%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: 72 uncovered changes across 16 files (129 of 201 lines covered, 64.18%).
  • 4 coverage regressions across 4 files.

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
src/describe/mod.rs 12 1 8.33%
crates/macros/src/impl_.rs 18 8 44.44%
crates/macros/src/lib.rs 28 18 64.29%
src/internal/class.rs 8 0 0.0%
crates/macros/src/enum_.rs 10 5 50.0%
crates/macros/src/interface.rs 21 16 76.19%
src/builders/class.rs 12 7 58.33%
crates/macros/src/impl_interface.rs 10 6 60.0%
src/builders/module.rs 4 0 0.0%
crates/macros/src/class.rs 11 9 81.82%
Total (18 files) 201 129 64.18%

Coverage Regressions

4 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
crates/macros/src/function.rs 1 91.45%
crates/macros/src/impl_.rs 1 88.27%
crates/macros/src/interface.rs 1 93.06%
src/describe/mod.rs 1 85.0%

Coverage Stats

Coverage Status
Relevant Lines: 13924
Covered Lines: 9670
Line Coverage: 69.45%
Coverage Strength: 52.35 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Sep 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing fix/macro-silent-attributes (a22bbb6) with master (1bfc9aa)

Open in CodSpeed

@ptondereau
ptondereau marked this pull request as ready for review September 20, 2026 17:38
@ptondereau
ptondereau merged commit a25eb73 into master Sep 20, 2026
73 checks passed
@ptondereau
ptondereau deleted the fix/macro-silent-attributes branch September 20, 2026 17:43
@Xenira Xenira mentioned this pull request Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants