fix(macro)!: no silently ignored macro attribute - #788
Merged
Merged
Conversation
ptondereau
force-pushed
the
fix/macro-silent-attributes
branch
from
September 20, 2026 17:14
f9a827d to
a22bbb6
Compare
Coverage Report for CI Build 35525251129Coverage decreased (-0.04%) to 69.448%Details
Uncovered Changes
Coverage Regressions4 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Macro options and arguments that parsed and then did nothing are now compile errors that point at the offending token, and class constants inside
#[php_impl]accept#[php(vis = ...)]. The migration guide lists each removed option and the newConstantFlagsparameter onClassBuilder.Checklist