Fix misleading type_from_binary instructions in file-sniffer#1638
Merged
Conversation
This PR fixes a misleading sentence in the File Sniffer concept exercise. The `type_from_binary/1` function receives a binary file and determines the media type from the file signature. The previous wording mentioned the extension not matching, but extensions are handled by `type_from_extension/1` and `verify/2`. This change clarifies that `type_from_binary/1` returns `nil` when the file signature does not match the expected ones.
Contributor
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
angelikatyborska
approved these changes
Jun 17, 2026
angelikatyborska
left a comment
Member
There was a problem hiding this comment.
Thank you, this makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a misleading sentence in the File Sniffer concept exercise.
The
type_from_binary/1function receives a binary file and determines the media type from the file signature. The previous wording mentioned the extension not matching, but extensions are handled bytype_from_extension/1andverify/2.This change clarifies that
type_from_binary/1returnsnilwhen the file signature does not match the expected ones.