Repository navigation
Drop Rails 7.0 support - #582
Merged
Merged
Conversation
Rails 7.0 is EOL. Requires rails >= 7.1 and removes the branches that only existed for 7.0: the serialize coder: keyword check, the perform_all_later shim in EventJob, the HtmlSafeTranslation guard, and the fixture_path fallback in the test helper. Also bumps the deprecation horizon to 4.0, since the 2.x deprecations (Noticed::Base, deliver_by :database, param/params) are still shipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rails 7.0 is EOL. Requires
rails >= 7.1.0.rails-7-0from Appraisals, delete its gemfile/lock, drop it from all three CI matrices (and the Ruby 3.4/4.0 excludes that only existed for it).serializecoder:keyword check inEvent, theperform_all_latershim inEventJob, theHtmlSafeTranslationguard inTranslation, and thefixture_pathfallback intest_helper."3.0"to"4.0"— the 2.x deprecations (Noticed::Base,deliver_by :database,param/params) are still shipping in 3.x.Test plan
standardrbcleanrails teston main Gemfile, Rails 7.1, 7.2, 8.0, 8.1, main — 152 runs, 0 failures each