feat: add current_title and reference_title to RenderOptions#1877
Open
SuryaSunil1326 wants to merge 1 commit into
Open
feat: add current_title and reference_title to RenderOptions#1877SuryaSunil1326 wants to merge 1 commit into
SuryaSunil1326 wants to merge 1 commit into
Conversation
Adds `current_title` (default "Current") and `reference_title` (default "Reference") fields to `RenderOptions`, and threads them through all data-drift renderer methods that previously hardcoded those strings in scatter plots, distribution charts, and tables. Closes evidentlyai#820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #820.
Adds
current_title(defaultCurrent) andreference_title(defaultReference) fields toRenderOptions, making the dataset labels in all data-drift visualizations configurable instead of hardcoded.Changes:
RenderOptionsinlegacy/options/agg_data.py— two new fields with backwards-compatible defaultsplot_scatter_for_data_driftinlegacy/utils/visualizations.py— acceptscurrent_titleparameterColumnDriftMetric,DataDriftTable,TextDescriptorsDriftMetricrenderers — passcurrent_titlethrough to scatter plotsColumnValuePlotrenderer — passes both titles to the raw scatter render methodTargetByFeaturesTablerenderer — passes both titles to regression/classification figure helpersUsage
Test plan
test_column_drift_metric_custom_titles— runs aColumnDriftMetricreport with custom titles and verifies the dashboard builds without errortests/metrics/data_drift/test_column_drift_metric.pystill pass